New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CMake] Updated CMake script to change layout of build files. #1224
Conversation
Hi, @AYESDIE! This can be done with 3 lines of code.
also |
@ice0 Ah, rather than going for a per-target basis, updating those directory in the root Should I make changes on how |
Yes. Also this will be much easier to support in the future.
I did not think about them. Therefore, I suggest just skipping them for now and back to them later. |
7462e81
to
590c680
Compare
Agreed :) I force pushed the new changes. I removed the |
@AYESDIE, also i want to ask, which OS you are using? |
I am on Ubuntu 19.10. |
Awesome! Also forgot to mention, please change the path to ${CMAKE_BINARY_DIR}/output/->lib/bin/etc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please squash commits :)
ed86529
to
3130944
Compare
I was building on my end to make sure things were in correct places :)) |
Ok, also please check P.S. use |
3130944
to
86e7831
Compare
It worked the way it was before too, since I kept on checking it with |
Awesome work! This is exactly what I wanted! Therefore, I propose to continue tomorrow. P.S. I will merge your changes after all the checks have been completed. |
Thank you for guiding :) The next thing will be to refactor the |
Yes. But i want to add one more simple issue for tomorrow. In this way, new students will be able to use IDEs such as CLion or NetBeans to build Synfig Studio and check they changes. |
Ah, sounds good to me. I'll take a look at it tomorrow :) |
@@ -43,6 +43,9 @@ set(MODS_ENABLED | |||
# mptr_mplayer # - "This code has vulnerabilities" | |||
) | |||
|
|||
set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/output/lib/modules) | |||
set(CMAKE_LIBRARY_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/output/lib/modules) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checked. This path must be lib/synfig/modules
not lib/modules
.
86e7831
to
8d946dd
Compare
Merged! Thank you! |
Fixes on #1131.
Changes:
CMakeLists.txt
. Inside the build folder, it makesbin
andlib
(ETL,include). Execution still require these commands..gitignore
.